This would have been in 1915-1916 since Elsie, Marshall and Maurice visited Herb in Montreal, where he briefly served as a recruiter in the the military from August to November 1916. Elsie had spent the first two decades of her life in the Annapolis Valley and had many close relatives and friends there; but the particular occasion of the Nova Scotia stay may have been the 1915 death of her paternal grandfather, John Henry Hall (1836-1915). In addition, her maternal grandmother, Susan Starratt Marshall (1835-1914) had died the year before that. Her maternal grandfather, Theodore Harding Marshall (1837-1934) and paternal grandmother, Naomi Ogilvie Hall (1834-1928) remained alive and Elsie and the boys, almost certainly also with Elsie’s mother, Margaret Marshall Hall (1861-1931), would have stayed with both over the course of their long visit.
At the LDS Family Search site, there is a picture of Herb in uniform with his two boys labeled ‘Montreal 1916’. Herb was discharged from the army in November 1916 due to illness, although he had served only a few months.